Seller - setting status of sold item to Payment Received

[RWAP]

There is an issue with v3.3 in that on the user/soldItems page, if the seller ticks the box to say payment has been received, the status actually shows 'Not Paid by Buyer' in Red, with 'Payment Verified' underneath in green.

The issue is in themes\default\soldItems.php, where

Code: Select all

<span class="<?=$offerStatus->paid? 'green':'red'?>Text"><strong><?=$offerStatus->paid? _('Paid by buyer'):_('Not paid by buyer')?></strong></span>

Should surely read:

Code: Select all

<span class="<?=($offerStatus->paid || $offerStatus->verifiedPayment)? 'green':'red'?>Text"><strong><?=($offerStatus->paid || $offerStatus->verifiedPayment)? _('Paid by buyer'):_('Not paid by buyer')?></strong></span>

Or better still, maybe change that section from:

Code: Select all

                                        <? if($v['type']==Offer::LOT){?>
                                            <input type="hidden" name="bidId" value="<?=$v['bidId']?>" />
                                        <?}?>
                                        <span class="<?=$offerStatus->paid? 'green':'red'?>Text"><strong><?=$offerStatus->paid? _('Paid by buyer'):_('Not paid by buyer')?></strong></span>
                                        <div class="clear"></div>
                                        <? if($offerStatus->verifiedPayment){ ?>
                                            <span class="greenText"><strong><?=_('Payment verified')?></strong></span>
                                        <?
                                        }else{
                                        ?>
                                            <label>
                                                <input type="checkbox" name="verifiedPayment" value="1" /> <span><?=_('Payment received')?></span>
                                            </label>
                                        <?
                                        }
                                        ?>

to read:

Code: Select all

                                        <? if($v['type']==Offer::LOT){?>
                                            <input type="hidden" name="bidId" value="<?=$v['bidId']?>" />
                                        <?}?>
                                        <? if($offerStatus->verifiedPayment){ ?>
                                            <span class="greenText"><strong><?=_('Payment verified')?></strong></span>
                                        <?
                                        }else{
                                        ?>
                                            <span class="<?=$offerStatus->paid? 'green':'red'?>Text"><strong><?=$offerStatus->paid? _('Paid by buyer'):_('Not paid by buyer')?></strong></span>
                                            <div class="clear"></div>
                                            <label>
                                                <input type="checkbox" name="verifiedPayment" value="1" /> <span><?=_('Payment received')?></span>
                                            </label>
                                        <?
                                        }
                                        ?>

Similar issues apply to the themes\default\userWonAuctions.php