Search found 220 matches

by bamse
Wed Mar 19, 2014 10:07 pm
Forum: Bugs
Topic: Truncating strings
Replies: 1
Views: 276

Truncating strings

Not sure whether this is an issue in newer versions of phpauction. Following is for my ancient v 2.11 In several places (e.g. in userProfile.php), strings are truncated in output using just substr($string) This can create at least two problems: 1. strange characters can appear in UTF-8 encoded strin...
by bamse
Wed Jan 22, 2014 6:15 pm
Forum: General Discussion
Topic: Invoices and bidding
Replies: 1
Views: 281

Invoices and bidding

I am somewhat confused (since I did not use the invoice system before), so the following questions are perhaps silly:

1. class/Invoice.php is only for fees, and not for payment of lots?
2. class/UserPayMethod.php is for payment of lots (and not of fees)?
by bamse
Sat Jan 18, 2014 12:16 pm
Forum: General Discussion
Topic: User registration validation
Replies: 1
Views: 261

User registration validation

It seems that the javascript validation (in global.js->validateUserForm() ) is more strict requiring certain minimum lengths of strings than the php validation (in class/User.php->__set() and class/Action/User.php->verifyUserParameters() ). So if I turn off javascript in the browser I could register...
by bamse
Wed Jan 15, 2014 9:53 am
Forum: General Discussion
Topic: Reverse auction invoicing
Replies: 1
Views: 267

Reverse auction invoicing

Also for v2.11 (at least) the whole invoicing system for reverse auctions seems broken to me. Basically it is currently set in the same way as for regular auctions, but in reverse auctions buyer and seller should be reversed. The user who set up an auction should be billed and not the winning bidder.
by bamse
Mon Jan 13, 2014 11:18 pm
Forum: General Discussion
Topic: Reverse auction decrement
Replies: 4
Views: 420

Re: Reverse auction decrement

That code is for v2.11 which is the newest version I have. No idea whether there have been any changes in v3.
by bamse
Mon Jan 13, 2014 10:16 pm
Forum: General Discussion
Topic: Reverse auction decrement
Replies: 4
Views: 420

Reverse auction decrement

I looked into reverse auctions recently and it seems that the new bid cannot be more than: current bid value minus 1 unit of currency. This is due to the line: return ($this->currentPrice -1)<0 ? 0: $this->currentPrice -1 ; //just one less is enough in class/ReverseAuction->calculateNextBid() Someho...
by bamse
Sun Sep 08, 2013 8:25 pm
Forum: General Discussion
Topic: Defer loading of javascript
Replies: 4
Views: 1114

Re: Defer loading of javascript

Why didn't you defer more? Using pagespeed to "profile deferrable javascript", I get the message: 100% of the JavaScript loaded by this page had not been invoked by the time the onload handler completed. which seems to suggest that all javascript could be deferred. Also looking at the actual code, a...
by bamse
Sun Sep 08, 2013 11:47 am
Forum: General Discussion
Topic: Defer loading of javascript
Replies: 4
Views: 1114

Re: Defer loading of javascript

I think the problem is that global.js needs to be loaded after fancybox. Defering global.js as well and after fancybox, seems to solve this problem.

Now I only need to figure out whether there is any code in global.js which should not be defered (because it is needed for rendering)...
by bamse
Sun Sep 08, 2013 6:45 am
Forum: General Discussion
Topic: Defer loading of javascript
Replies: 4
Views: 1114

Defer loading of javascript

I am trying to defer the loading of javascript using the method outlined in https://developers.google.com/speed/docs/best-practices/payload?csw=1#DeferLoadingJS Tried this with the fancybox js file and from the timeline in developer tools it seems that the file is loaded later (after the red line). ...
by bamse
Sun Sep 08, 2013 6:19 am
Forum: Free Modifications
Topic: CSV Export improvements
Replies: 1
Views: 403

Re: CSV Export improvements

Not sure if this is relevant here, but wanted to share my own struggles with Excel:

For some reason Excel required the file to have extension csv and would not read the same file if it had extension tsv for instance.

The free Excel (Starter) would not read csv files at all.